linux-kernel - Re: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52d287b6-f6e4-4644-aef8-2c22bff59613@acm.org>
Date: Wed, 22 Jan 2025 10:39:18 -0800
From: Bart Van Assche <bvanassche@....org>
To: Avri Altman <avri.altman@....com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 Manivannan Sadhasivam <manisadhasivam.linux@...il.com>,
 Can Guo <cang@....qualcomm.com>
Subject: Re: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c

On 1/22/25 6:36 AM, Avri Altman wrote:
> +static ssize_t
> +clkgate_enable_show(struct device *dev, struct device_attribute *attr,
> +		    char *buf)
> +{

The above formatting does not conform to the Linux kernel coding style. 
Please fix this, e.g. by running git clang-format HEAD^ && git commit 
--amend on the git branch with this patch.

> +	if (kstrtou32(buf, 0, &value))
> +		return -EINVAL;
> +
> +	value = !!value;

Please use kstrtobool() instead of the above code.

Thanks,

Bart.