linux-kernel - RE: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB657584F352A1AD45FBD7B23DFCE02@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Thu, 23 Jan 2025 07:31:05 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Manivannan
 Sadhasivam <manisadhasivam.linux@...il.com>, Can Guo <cang@....qualcomm.com>
Subject: RE: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c

> On 1/22/25 6:36 AM, Avri Altman wrote:
> > +static ssize_t
> > +clkgate_enable_show(struct device *dev, struct device_attribute *attr,
> > +                 char *buf)
> > +{
> 
> The above formatting does not conform to the Linux kernel coding style.
> Please fix this, e.g. by running git clang-format HEAD^ && git commit --amend
> on the git branch with this patch.
Done.
AFAIK, there hasn't been a formal announcement that `clang-format` should replace `checkpatch` for Linux kernel development.
And yes, while checkpatch --strict accepted the above formatting, clang-format did make changes.


> 
> > +     if (kstrtou32(buf, 0, &value))
> > +             return -EINVAL;
> > +
> > +     value = !!value;
> 
> Please use kstrtobool() instead of the above code.
Done.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.