linux-kernel - Re: [PATCH net 2/2] net: sh_eth: Fix missing rtnl lock in suspend path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0df2838-cd28-4403-83ca-883fece75a71@omp.ru>
Date: Wed, 22 Jan 2025 21:39:04 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Kory Maincent <kory.maincent@...tlin.com>, Paul Barker
	<paul.barker.ct@...renesas.com>, Niklas Söderlund
	<niklas.soderlund@...natech.se>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>, <netdev@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 2/2] net: sh_eth: Fix missing rtnl lock in suspend
 path

On 1/22/25 7:19 PM, Kory Maincent wrote:

> Fix the suspend path by ensuring the rtnl lock is held where required.

   Maybe suspend/resume path (the same w/the subject)?

> Calls to sh_eth_close, sh_eth_open and wol operations must be performed
> under the rtnl lock to prevent conflicts with ongoing ndo operations.
> 
> Fixes: b71af04676e9 ("sh_eth: add more PM methods")
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>

    FWIW:

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey