linux-kernel - Re: [PATCH] xfs: Propagate errors from xfs_reflink_cancel_cow_range in xfs_dax_write_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250122032504.GT3557553@frogsfrogsfrogs>
Date: Tue, 21 Jan 2025 19:25:04 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: chandanbabu@...nel.org, cem@...nel.org, brauner@...nel.org,
	dchinner@...hat.com, yi.zhang@...wei.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: Propagate errors from xfs_reflink_cancel_cow_range
 in xfs_dax_write_iomap_end

On Tue, Jan 21, 2025 at 12:09:06AM +0800, Wentao Liang wrote:
> In xfs_dax_write_iomap_end(), directly return the result of
> xfs_reflink_cancel_cow_range() when !written, ensuring proper
> error propagation and improving code robustness.
> 
> Fixes: ea6c49b784f0 ("xfs: support CoW in fsdax mode")
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  fs/xfs/xfs_iomap.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index 50fa3ef89f6c..d61460309a78 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -976,10 +976,8 @@ xfs_dax_write_iomap_end(
>  	if (!xfs_is_cow_inode(ip))
>  		return 0;
>  
> -	if (!written) {
> -		xfs_reflink_cancel_cow_range(ip, pos, length, true);
> -		return 0;
> -	}
> +	if (!written)
> +		return xfs_reflink_cancel_cow_range(ip, pos, length, true);

Ouch.  Yeah, that's clearly wrong.  Please add my tags:

Cc: <stable@...r.kernel.org> # v6.0
Reviewed-by: "Darrick J. Wong" <djwong@...nel.org>

--D

>  
>  	return xfs_reflink_end_cow(ip, pos, written);
>  }
> -- 
> 2.42.0.windows.2
>