Message-ID: <f580de56-64c8-4a75-90e6-cee7783e6cfe@linux.dev>
Date: Wed, 22 Jan 2025 11:25:15 +0800
From: Chengming Zhou <chengming.zhou@...ux.dev>
To: Hyeonggon Yoo <42.hyeyoo@...il.com>, Hyesoo Yu <hyesoo.yu@...sung.com>
Cc: janghyuck.kim@...sung.com, Christoph Lameter <cl@...ux.com>,
 Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>,
 Joonsoo Kim <iamjoonsoo.kim@....com>,
 Andrew Morton <akpm@...ux-foundation.org>, Vlastimil Babka <vbabka@...e.cz>,
 Roman Gushchin <roman.gushchin@...ux.dev>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: slub: Print the broken data before restoring slub.

On 2025/1/21 21:35, Hyeonggon Yoo wrote:
> On Mon, Jan 20, 2025 at 5:31 PM Hyesoo Yu <hyesoo.yu@...sung.com> wrote:
> 
> Let's add Chengming, the author of the commit, to Cc,
> as he might have some opinions about it.

Thanks!

> 
>> Previously, the restore occured after printing the object in slub.
>> After commit 47d911b ("slab: make check_object() more consistent"),
> 
> at least 12 characters of the commit hash should be used to refer to a commit.
> Documentation/process/submitting-patches.rst states that:
>      You should also be sure to use at least the first twelve
> characters of the SHA-1 ID.
>      The kernel repository holds a lot of objects, making collisions
> with shorter IDs a real
>      possibility. Bear in mind that, even if there is no collision with
> your six-character ID
>      now, that condition may change five years from now.
> 
>> the bytes are printed after the restore. This information about the bytes

Yes, object will be dumped once we found one error and abort checking
before this commit, which changed to check all sections of the object
and dump the object at last, then corrupted section has been restored.

>> before the restore is highly valuable for debugging purpose.
>> For instance, in a event of cache issue, it displays byte patterns
>> by breaking them down into 64-bytes units. Without this information,

Actually, we already print the error message of corrupted section in
check_bytes_and_report() of each section checking, but it's not enough
for your case. So you add print_section(), which makes sense to me.

>> we can only speculate on how it was broken. Hence the corrupted regions
>> are printed prior to the restoration process.
> 
> Probably this should be considered for -stable releases. What do you think?
> [1] https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

I'm not sure since it's not bug, just the printed message is not enough
in this usecase.

> 
>> diff --git a/mm/slub.c b/mm/slub.c
>> index c2151c9fee22..48cefc969480 100644
>> --- a/mm/slub.c
>> +++ b/mm/slub.c
>> @@ -1207,6 +1207,7 @@ check_bytes_and_report(struct kmem_cache *s, struct slab *slab,
>>                                          fault[0], value);
>>
>>   skip_bug_print:
>> +       print_section(KERN_ERR, "Corrupt  ", fault, end - fault);
> 
> I don't think it's supposed to report an error here, per the name of
> the label "skip_bug_print".

Agree, I think print_section() should be above skip_bug_print,
which means we should skip printing bug message when kunit testing.

Here you just print the "Corrupt" part of this section, another choice
is just print this whole section, not sure which way is better.

> 
> Maybe move print_trailer() and add_taint() back to
> check_bytes_and_report(), and report an error
> only once and skip reporting if it's already reported?

Here is the dicussion[1].

[1] 
https://lore.kernel.org/all/20240528-b4-slab-debug-v1-1-8694ef4802df@linux.dev/

Thanks.

> 
> Best,
> Hyeonggon
> 
>>          restore_bytes(s, what, value, fault, end);
>>          return 0;
>>   }
>> --
>> 2.48.0
>>

Powered by blists - more mailing lists