linux-kernel - Re: [PATCH v6 2/3] pwm: sophgo: add driver for Sophgo SG2042 PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BM1PR01MB254554818778F4EC9449EC68FEE12@BM1PR01MB2545.INDPRD01.PROD.OUTLOOK.COM>
Date: Wed, 22 Jan 2025 19:54:26 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Uwe Kleine-König <ukleinek@...nel.org>
Cc: Chen Wang <unicornxw@...il.com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, inochiama@...look.com, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org,
 linux-riscv@...ts.infradead.org, chao.wei@...hgo.com,
 haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com, chunzhi.lin@...hgo.com,
 Sean Young <sean@...s.org>
Subject: Re: [PATCH v6 2/3] pwm: sophgo: add driver for Sophgo SG2042 PWM


On 2025/1/22 18:03, Uwe Kleine-König wrote:
> The rational is usually that
>
> 	mul_u64_u64_div_u64(ddata->clk_rate_hz, state->period, NSEC_PER_SEC)
>
> cannot overflow. Your driver relies on that, too. (Which somewhat
> proves that a comment is indeed necessary 🙂

Oh, thanks for pointing that out, I almost forgot about that. Will check 
this out in the next version.

Regards,

Chen