linux-kernel - Re: [PATCH bpf-next v7 0/5] bpf: Add open-coded style process file iterator and bpf_fget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM6PR03MB5080EA6AC9C1DCA2A2359D8D99E12@AM6PR03MB5080.eurprd03.prod.outlook.com>
Date: Wed, 22 Jan 2025 13:36:09 +0000
From: Juntong Deng <juntong.deng@...look.com>
To: ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com,
 andrii@...nel.org, martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
 yonghong.song@...ux.dev, kpsingh@...nel.org, sdf@...ichev.me,
 haoluo@...gle.com, jolsa@...nel.org, memxor@...il.com, snorcht@...il.com,
 brauner@...nel.org
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH bpf-next v7 0/5] bpf: Add open-coded style process file
 iterator and bpf_fget_task() kfunc

On 2025/1/21 15:20, Juntong Deng wrote:
> I noticed that the errors in Kernel CI
> 
> progs/iters_task_file.c: In function ‘test_bpf_iter_task_file’:
>    progs/iters_task_file.c:43:33: error: taking address of expression of 
> type ‘void’ [-Werror]
>       43 |         if (item->file->f_op != &pipefifo_fops) {
>          |                                 ^
>    progs/iters_task_file.c:59:33: error: taking address of expression of 
> type ‘void’ [-Werror]
>       59 |         if (item->file->f_op != &pipefifo_fops) {
>          |                                 ^
>    progs/iters_task_file.c:75:33: error: taking address of expression of 
> type ‘void’ [-Werror]
>       75 |         if (item->file->f_op != &socket_file_ops) {
>          |                                 ^
> 
> These errors are caused by -Werror (treat all warnings as errors).
> 
> In this test case, we do need to get the address of void type.

I found out that these errors were caused by removing the 'const'
in front of 'void'.

I will add back 'const' in the next version.