linux-kernel - Re: [PATCH v5 01/10] dt-bindings: media: Add amlogic,c3-mipi-csi2.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x57kn2zaxl5ep4owimw456jsao6ictnkilsfhrrbkr4ty3y6hw@bfc625f7rat7>
Date: Wed, 22 Jan 2025 15:00:34 +0100
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Jacopo Mondi <jacopo.mondi@...asonboard.com>, 
	Keke Li <keke.li@...ogic.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kieran.bingham@...asonboard.com, 
	laurent.pinchart@...asonboard.com, dan.scally@...asonboard.com
Subject: Re: [PATCH v5 01/10] dt-bindings: media: Add
 amlogic,c3-mipi-csi2.yaml

Hi Krzysztof

On Wed, Jan 22, 2025 at 02:48:07PM +0100, Krzysztof Kozlowski wrote:
> On 22/01/2025 14:36, Jacopo Mondi wrote:
> >>>> +  assigned-clocks: true
> >>>> +
> >>>> +  assigned-clock-rates: true
> >>> NAK
> >>>
> >>> Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak
> >>> whatever crap past reviewers.
> >>>
> >>> Drop all new properties and drop my review tag.
> >>
> >>
> >> OK, will drop all new properties and drop your review tag. Thanks
> >>
> >
> > Krzysztof why should new properties added in-between two revisions be
> > dropped ?
>
> You connected two independent issues.

Well, it seems Keke did as well:

> >> OK, will drop all new properties and drop your review tag. Thanks

If new properties get removed, the tag can then stay, right ?

> It is not that some new properties should be dropped, because I don't
> like new stuff. It's that these two particular properties - added in
> this version, but that's coincidence - are not appropriate and should be
> dropped because of that reason: not appropriateness.
>
> >
> > I understand the "drop my tag if you make changes" but I don't get why
> > the newly added properties should be removed.
>
> They are neither needed, nor beneficial. Core schema provides them.
>

Ok, this is the bit I was missing. I thought that having

  additionalProperties: false

in the schema means that properties not explicitly listed are not
valid, but schema validation passes without specifying the two
properties, so yeah, these should be dropped.


> Best regards,
> Krzysztof