linux-kernel - Re: [PATCH v5 01/10] dt-bindings: media: Add amlogic,c3-mipi-csi2.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd993f74-1d95-4cb8-b6d4-dfbe0931a03d@linaro.org>
Date: Wed, 22 Jan 2025 14:48:07 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jacopo Mondi <jacopo.mondi@...asonboard.com>,
 Keke Li <keke.li@...ogic.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 kieran.bingham@...asonboard.com, laurent.pinchart@...asonboard.com,
 dan.scally@...asonboard.com
Subject: Re: [PATCH v5 01/10] dt-bindings: media: Add
 amlogic,c3-mipi-csi2.yaml

On 22/01/2025 14:36, Jacopo Mondi wrote:
>>>> +  assigned-clocks: true
>>>> +
>>>> +  assigned-clock-rates: true
>>> NAK
>>>
>>> Adding new properties *INVALIDATES REVIEW*. Otherwise you can sneak
>>> whatever crap past reviewers.
>>>
>>> Drop all new properties and drop my review tag.
>>
>>
>> OK, will drop all new properties and drop your review tag. Thanks
>>
> 
> Krzysztof why should new properties added in-between two revisions be
> dropped ?

You connected two independent issues.

It is not that some new properties should be dropped, because I don't
like new stuff. It's that these two particular properties - added in
this version, but that's coincidence - are not appropriate and should be
dropped because of that reason: not appropriateness.

> 
> I understand the "drop my tag if you make changes" but I don't get why
> the newly added properties should be removed.

They are neither needed, nor beneficial. Core schema provides them.

Best regards,
Krzysztof