linux-kernel - Re: [PATCH v5 05/10] dt-bindings: media: Add amlogic,c3-isp.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jja74umhccvvg2nmolavpuaafsqrqj6pylyrblhcem4so4hz2j@fyutf4duwyrv>
Date: Wed, 22 Jan 2025 14:38:34 +0100
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: keke.li@...ogic.com, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kieran.bingham@...asonboard.com, 
	laurent.pinchart@...asonboard.com, dan.scally@...asonboard.com, jacopo.mondi@...asonboard.com
Subject: Re: [PATCH v5 05/10] dt-bindings: media: Add amlogic,c3-isp.yaml

On Fri, Dec 27, 2024 at 08:22:22AM +0100, Krzysztof Kozlowski wrote:
> On 27/12/2024 08:09, Keke Li via B4 Relay wrote:
> > +
> > +  clocks:
> > +    maxItems: 2
> > +
> > +  clock-names:
> > +    items:
> > +      - const: vapb
> > +      - const: isp0
> > +
> > +  assigned-clocks: true
> > +
> > +  assigned-clock-rates: true
>
> No, drop these. Request re-review if you add new properties.

Why ?

I think the patches should be re-checked and it's fair to ask to drop
the rb tag. But the idea that patches once reviewed should not be
modified between two different versions of the same set seems really..
debatable ?

>
> Best regards,
> Krzysztof
>