linux-kernel - Re: [PATCH] dmaengine: ti: k3-udma-glue: Drop skip_fdq argument from k3_udma_glue_reset_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <decd473c-289d-44be-b882-3f2bb15c0d57@gmail.com>
Date: Wed, 22 Jan 2025 17:10:31 +0200
From: Péter Ujfalusi <peter.ujfalusi@...il.com>
To: Roger Quadros <rogerq@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 MD Danish Anwar <danishanwar@...com>,
 Siddharth Vadapalli <s-vadapalli@...com>,
 Vignesh Raghavendra <vigneshr@...com>
Cc: srk@...com, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dmaengine: ti: k3-udma-glue: Drop skip_fdq argument from
 k3_udma_glue_reset_rx_chn

On 16/01/2025 17:00, Roger Quadros wrote:
> The user of k3_udma_glue_reset_rx_chn() e.g. ti_am65_cpsw_nuss can
> run on multiple platforms having different DMA architectures.
> On some platforms there can be one FDQ for all flows in the RX channel
> while for others there is a separate FDQ for each flow in the RX channel.
> 
> So far we have been relying on the skip_fdq argument of
> k3_udma_glue_reset_rx_chn().
> 
> Instead of relying on the user to provide this information, infer it
> based on DMA architecture during k3_udma_glue_request_rx_chn() and save it
> in an internal flag 'single_fdq'. Use that flag at
> k3_udma_glue_reset_rx_chn() to deicide if the FDQ needs
> to be cleared for every flow or just for flow 0.

This should have been the original approach, there are things that
clients must not care.

Acked-by: Peter Ujfalusi <peter.ujfalusi@...il.com>