linux-kernel - Re: [PATCH for-current] wifi: ath12k: fix handling of 6 GHz rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d39befa5-58cd-4052-a71f-c632462ccce0@oss.qualcomm.com>
Date: Thu, 23 Jan 2025 09:12:37 -0800
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Aditya Kumar Singh <aditya.kumar.singh@....qualcomm.com>,
        Kalle Valo <kvalo@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
        Vasanthakumar Thiagarajan <quic_vthiagar@...cinc.com>,
        Baochen Qiang <quic_bqiang@...cinc.com>,
        Wen Gong <quic_wgong@...cinc.com>,
        Karthikeyan Periyasamy <quic_periyasa@...cinc.com>,
        Pradeep Kumar Chitrapu <quic_pradeepc@...cinc.com>
Cc: Balamurugan Selvarajan <quic_bselvara@...cinc.com>,
        Ramya Gnanasekar <quic_rgnanase@...cinc.com>,
        P Praneesh <quic_ppranees@...cinc.com>,
        Bhagavathi Perumal S <quic_bperumal@...cinc.com>,
        linux-wireless@...r.kernel.org, ath12k@...ts.infradead.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH for-current] wifi: ath12k: fix handling of 6 GHz rules

On 1/23/2025 8:21 AM, Aditya Kumar Singh wrote:
> In the US country code, to avoid including 6 GHz rules in the 5 GHz rules
> list, the number of 5 GHz rules is set to a default constant value of 4
> (REG_US_5G_NUM_REG_RULES). However, if there are more than 4 valid 5 GHz
> rules, the current logic will bypass the legitimate 6 GHz rules.
> 
> For example, if there are 5 valid 5 GHz rules and 1 valid 6 GHz rule, the
> current logic will only consider 4 of the 5 GHz rules, treating the last
> valid rule as a 6 GHz rule. Consequently, the actual 6 GHz rule is never
> processed, leading to the eventual disabling of 6 GHz channels.
> 
> To fix this issue, instead of hardcoding the value to 4, use a helper
> function to determine the number of 6 GHz rules present in the 5 GHz rules
> list and ignore only those rules.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
> 
> Cc: stable@...r.kernel.org

Note that an upcoming linux-firmware PR will bring in firmware that triggers
this issue, so want to get all affected versions of the driver patched before
issuing that PR.

/jeff