linux-kernel - Re: [PATCH v4 2/3] drm/panel: boe-tv101wum-nl6: support for kingdisplay-kd110n11-51ie MIPI-DSI panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Wt+6AoycUfcWaEAi2ucTN_37CvE6VQZF5iHU0+Aj-gZQ@mail.gmail.com>
Date: Thu, 23 Jan 2025 09:46:37 -0800
From: Doug Anderson <dianders@...omium.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, thierry.reding@...il.com, sam@...nborg.org, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] drm/panel: boe-tv101wum-nl6: support for
 kingdisplay-kd110n11-51ie MIPI-DSI panel

Hi,

On Wed, Jan 22, 2025 at 10:48 PM Langyan Ye
<yelangyan@...qin.corp-partner.google.com> wrote:
>
> The kingdisplay-kd110n11-51ie is a 10.95" TFT panel.
> which fits in nicely with the existing panel-boe-tv101wum-nl6 driver.
> From the datasheet, MIPI needs to keep the LP11 state before the
> lcm_reset pin is pulled high, so increase lp11_before_reset flag.
>
> Signed-off-by: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
> ---
>  .../gpu/drm/panel/panel-boe-tv101wum-nl6.c    | 122 ++++++++++++++++++
>  1 file changed, 122 insertions(+)

You have Neil's review tag (carried from your V1), so in theory this
could land once the bindings are reviewed. ...but as I talked about in
my response [1] to your bindings patch, I'd like some confidence that
the MIPI controller on the new panels you're adding is actually the
same as the other panels here. If not then IMO you should add them to
a different driver or create a new driver.

[1] https://lore.kernel.org/r/CAD=FV=Vr5DnACFoQnnFzPhF778Nv6LOZj43BqZX6vW_azMARZQ@mail.gmail.com


> +static int kingdisplay_kd110n11_51ie_init(struct boe_panel *boe)
> +{
> +       struct mipi_dsi_multi_context ctx = { .dsi = boe->dsi };
> +
> +       msleep(50);
> +
> +       mipi_dsi_dcs_write_seq_multi(&ctx, 0xB9, 0x83, 0x10, 0x21, 0x55, 0x00);

nit: lower case hex please. 0xb9 instead of 0xB9.


> +       mipi_dsi_dcs_write_seq_multi(&ctx, 0xE9, 0xC4);
> +       mipi_dsi_dcs_write_seq_multi(&ctx, 0xD9, 0xD1);
> +       mipi_dsi_dcs_write_seq_multi(&ctx, 0xE9, 0x3F);
> +       mipi_dsi_dcs_write_seq_multi(&ctx, 0xB1, 0x2C, 0xB3, 0xB3, 0x31, 0xF1, 0x33, 0xE0, 0x54,
> +               0x36, 0x36, 0x3A, 0x3A, 0x32, 0x8B, 0x11, 0xE5, 0x98);

nit: ideally line up indentation so that the "0" in "0x36" is under
the "&" in "&ctx".