linux-kernel - Re: [PATCH -next 1/2] apparmor: Modify mismatched function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38ca7459-4034-4171-a231-6c06af1391f2@canonical.com>
Date: Fri, 24 Jan 2025 14:03:58 -0800
From: John Johansen <john.johansen@...onical.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
 apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next 1/2] apparmor: Modify mismatched function name

On 1/20/25 18:44, Jiapeng Chong wrote:
> No functional modification involved.
> 
> security/apparmor/file.c:184: warning: expecting prototype for aa_lookup_fperms(). Prototype was for aa_lookup_condperms() instead.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13605
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: John Johansen <john.johansen@...onical.com>

I have pulled this into my tree

> ---
>   security/apparmor/file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/file.c b/security/apparmor/file.c
> index 85f89814af1e..f113eedbc208 100644
> --- a/security/apparmor/file.c
> +++ b/security/apparmor/file.c
> @@ -169,7 +169,7 @@ static int path_name(const char *op, const struct cred *subj_cred,
>   
>   struct aa_perms default_perms = {};
>   /**
> - * aa_lookup_fperms - convert dfa compressed perms to internal perms
> + * aa_lookup_condperms - convert dfa compressed perms to internal perms
>    * @subj_uid: uid to use for subject owner test
>    * @rules: the aa_policydb to lookup perms for  (NOT NULL)
>    * @state: state in dfa