linux-kernel - Re: [PATCH -next 2/2] apparmor: Modify mismatched function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97669024-c5df-46dc-93bb-3b54f179db1d@canonical.com>
Date: Fri, 24 Jan 2025 14:05:32 -0800
From: John Johansen <john.johansen@...onical.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
 apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next 2/2] apparmor: Modify mismatched function name

On 1/20/25 18:44, Jiapeng Chong wrote:
> No functional modification involved.
> 
> security/apparmor/lib.c:93: warning: expecting prototype for aa_mask_to_str(). Prototype was for val_mask_to_str() instead.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13606
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: John Johansen <john.johansen@...onical.com>

I have pulled this into my tree

> ---
>   security/apparmor/lib.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/lib.c b/security/apparmor/lib.c
> index dd5dcbe5daf7..325f26f39a63 100644
> --- a/security/apparmor/lib.c
> +++ b/security/apparmor/lib.c
> @@ -82,7 +82,7 @@ int aa_parse_debug_params(const char *str)
>   }
>   
>   /**
> - * aa_mask_to_str - convert a perm mask to its short string
> + * val_mask_to_str - convert a perm mask to its short string
>    * @str: character buffer to store string in (at least 10 characters)
>    * @str_size: size of the @str buffer
>    * @chrs: NUL-terminated character buffer of permission characters