linux-kernel - Re: [PATCH] mfd: syscon: Restore device_node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250124220813.higrv36o7m77hsyk@unable>
Date: Fri, 24 Jan 2025 16:08:13 -0600
From: Nishanth Menon <nm@...com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: Lee Jones <lee@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Krzysztof
 Kozlowski <krzysztof.kozlowski@...aro.org>,
        Pankaj Dubey
	<pankaj.dubey@...sung.com>,
        Will McVicker <willmcvicker@...gle.com>,
        John
 Madieu <john.madieu.xa@...renesas.com>,
        Vaishnav Achath <vaishnav.a@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for
 non-syscon nodes

On 13:16-20250124, Rob Herring wrote:
> Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a
> "syscon" compatible") broke drivers which call device_node_to_regmap()
> on nodes without a "syscon" compatible. Restore the prior behavior for
> device_node_to_regmap().
> 
> This also makes using device_node_to_regmap() incompatible with
> of_syscon_register_regmap() again, so add kerneldoc for
> device_node_to_regmap() and syscon_node_to_regmap() to make it clear
> how and when each one should be used.
> 
> Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible")
> Cc: Will McVicker <willmcvicker@...gle.com>
> Cc: John Madieu <john.madieu.xa@...renesas.com>
> Cc: Nishanth Menon <nm@...com>
> Reported-by: Vaishnav Achath <vaishnav.a@...com>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Thanks Rob.

Tested with next-20250124 on TI K3 platforms

Tested-by: Nishanth Menon <nm@...com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D