linux-kernel - Re: [PATCH] clk: keystone: syscon-clk: Do not use syscon helper to build regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250124221257.z27tvyetd6mr74jn@recycled>
Date: Fri, 24 Jan 2025 16:12:57 -0600
From: Nishanth Menon <nm@...com>
To: Stephen Boyd <sboyd@...nel.org>
CC: Andrew Davis <afd@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Santosh
 Shilimkar <ssantosh@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        Rob Herring
	<robh@...nel.org>, Lee Jones <lee@...nel.org>
Subject: Re: [PATCH] clk: keystone: syscon-clk: Do not use syscon helper to
 build regmap

On 11:01-20250124, Stephen Boyd wrote:
> Quoting Nishanth Menon (2025-01-23 12:02:09)
> > On 12:19-20250123, Andrew Davis wrote:
> > > The syscon helper device_node_to_regmap() is used to fetch a regmap
> > > registered to a device node. It also currently creates this regmap
> > > if the node did not already have a regmap associated with it. This
> > > should only be used on "syscon" nodes. This driver is not such a
> > > device and instead uses device_node_to_regmap() on its own node as
> > > a hacky way to create a regmap for itself.
> > > 
> > > This will not work going forward and so we should create our regmap
> 
> Please reference the commit where this won't work anymore. It's hard to
> know the urgency without this information.
> 
> > > the normal way by defining our regmap_config, fetching our memory
> > > resource, then using the normal regmap_init_mmio() function.
> > > 
> > > Signed-off-by: Andrew Davis <afd@...com>
> > 
> > Tested-by: Nishanth Menon <nm@...com>
> > 
> > Could we get this routed to master as fixes asap please to get a sane 6.14?
> > 
> 
> Sure. Can you resend with a Fixes tag?


I think it is less urgent for immediate window given Rob has posted
a restoration of behavior fixup[1]. This patch is still good to be
merged based on [2].


[1] https://lore.kernel.org/all/20250124191644.2309790-1-robh@kernel.org/
[2] https://lore.kernel.org/all/CAL_JsqKVydDqmr-gyn1wt=1PO_p1NMze+1D+4qXWxGiGVLV9EA@mail.gmail.com/

> 
> > This is part of the fixes TI K3 platforms boot issues reported in
> > https://lore.kernel.org/all/b2413460-ec8b-4c77-99b8-4c32b262439a@ti.com/
> > 
> > on the latest linus master v6.13-5001-gd0d106a2bd21 + linux
> > next-20250123
> > 
> > Total set of patches tested with:
> > https://lore.kernel.org/all/20250119182121.3956546-1-vaishnav.a@ti.com/
> > https://lore.kernel.org/r/20250123181726.597144-1-afd@ti.com
> > https://lore.kernel.org/r/20250123181913.597304-1-afd@ti.com
> > https://lore.kernel.org/r/20250123182059.597491-1-afd@ti.com
> > https://lore.kernel.org/r/20250123182234.597665-1-afd@ti.com
> >

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D