linux-kernel - Re: [PATCH] clk: keystone: syscon-clk: Do not use syscon helper to build regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65e5503016f79f6c89219b5841c75b8c.sboyd@kernel.org>
Date: Tue, 04 Mar 2025 11:49:51 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Andrew Davis <afd@...com>, Michael Turquette <mturquette@...libre.com>, Nishanth Menon <nm@...com>, Santosh Shilimkar <ssantosh@...nel.org>, Vignesh Raghavendra <vigneshr@...com>
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, Andrew Davis <afd@...com>
Subject: Re: [PATCH] clk: keystone: syscon-clk: Do not use syscon helper to build regmap

Quoting Andrew Davis (2025-01-23 10:19:13)
> The syscon helper device_node_to_regmap() is used to fetch a regmap
> registered to a device node. It also currently creates this regmap
> if the node did not already have a regmap associated with it. This
> should only be used on "syscon" nodes. This driver is not such a
> device and instead uses device_node_to_regmap() on its own node as
> a hacky way to create a regmap for itself.
> 
> This will not work going forward and so we should create our regmap
> the normal way by defining our regmap_config, fetching our memory
> resource, then using the normal regmap_init_mmio() function.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---

Applied to clk-next