linux-kernel - Re: [PATCH] clk: keystone: syscon-clk: Do not use syscon helper to build regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b93a51bffd5ff7365d3998df92f0554.sboyd@kernel.org>
Date: Fri, 24 Jan 2025 11:01:53 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Andrew Davis <afd@...com>, Nishanth Menon <nm@...com>
Cc: Vignesh Raghavendra <vigneshr@...com>, Santosh Shilimkar <ssantosh@...nel.org>, Michael Turquette <mturquette@...libre.com>, linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, Rob Herring (Arm) <robh@...nel.org>, Lee Jones <lee@...nel.org>
Subject: Re: [PATCH] clk: keystone: syscon-clk: Do not use syscon helper to build regmap

Quoting Nishanth Menon (2025-01-23 12:02:09)
> On 12:19-20250123, Andrew Davis wrote:
> > The syscon helper device_node_to_regmap() is used to fetch a regmap
> > registered to a device node. It also currently creates this regmap
> > if the node did not already have a regmap associated with it. This
> > should only be used on "syscon" nodes. This driver is not such a
> > device and instead uses device_node_to_regmap() on its own node as
> > a hacky way to create a regmap for itself.
> > 
> > This will not work going forward and so we should create our regmap

Please reference the commit where this won't work anymore. It's hard to
know the urgency without this information.

> > the normal way by defining our regmap_config, fetching our memory
> > resource, then using the normal regmap_init_mmio() function.
> > 
> > Signed-off-by: Andrew Davis <afd@...com>
> 
> Tested-by: Nishanth Menon <nm@...com>
> 
> Could we get this routed to master as fixes asap please to get a sane 6.14?
> 

Sure. Can you resend with a Fixes tag?

> This is part of the fixes TI K3 platforms boot issues reported in
> https://lore.kernel.org/all/b2413460-ec8b-4c77-99b8-4c32b262439a@ti.com/
> 
> on the latest linus master v6.13-5001-gd0d106a2bd21 + linux
> next-20250123
> 
> Total set of patches tested with:
> https://lore.kernel.org/all/20250119182121.3956546-1-vaishnav.a@ti.com/
> https://lore.kernel.org/r/20250123181726.597144-1-afd@ti.com
> https://lore.kernel.org/r/20250123181913.597304-1-afd@ti.com
> https://lore.kernel.org/r/20250123182059.597491-1-afd@ti.com
> https://lore.kernel.org/r/20250123182234.597665-1-afd@ti.com
>