linux-kernel - Re: [PATCH v4 1/3] dt-bindings: display: panel: Add compatible for KD110N11-51IE and 2082109QFH040022-50E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=UNkjPH_i7+wJqbPGpugTmo=Ly2_1bj=-1SKS4fiaRAFQ@mail.gmail.com>
Date: Thu, 23 Jan 2025 20:27:16 -0800
From: Doug Anderson <dianders@...omium.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, simona@...ll.ch, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, thierry.reding@...il.com, sam@...nborg.org, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: display: panel: Add compatible for
 KD110N11-51IE and 2082109QFH040022-50E

Hi,

On Thu, Jan 23, 2025 at 7:54 PM Langyan Ye
<yelangyan@...qin.corp-partner.google.com> wrote:
>
> Hi Doug,
> Your suggestion is very helpful to me, thank you.

One note: when responding on mailing lists, please don't "top post". I
personally don't care that much, but many others do. See, for
instance;

https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying

I'm sure if you search the internet you can find lots of other
descriptions about top posting, including the usual:

A: No.
Q: Should I ever top-post?

> I confirmed the controller chips of these two panels, and it turned
> out that they use the HX83102 IC, so the correct approach is that I
> should add these two MIPI panels to the binding file/driver of the
> MIPI controller of HX83102.

Yes, that sounds correct to me. So you'd move the bindings patch to
add your compatible strings to:

Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml

...and you'd add the code to:

drivers/gpu/drm/panel/panel-himax-hx83102.c

...when you do this, please make sure you're following the conventions
of the "panel-himax-hx83102.c" driver file, like using the
hx83102_enable_extended_cmds() function when appropriate and using the
defines like "HX83102_SETPOWER", "HX83102_SETDISP", etc.

> I would like to ask if I need to release a
> v5 version or resend a new email if I do this?

IMO you'd call it v5. You should probably drop Neil's Reviewed-by tag
in this case since it's a major enough change that you'd want him to
re-provide a review. You could add a note to the version history like
"Dropped Neil's tags since V5 is very different from V4" or something
like that.

FWIW, for the bindings patch I would personally use the patch description:

Add a new compatible for the panels KINGDISPLAY KD110N11-51IE and
STARRY 2082109QFH040022-50E. Both panels use the HX83102 IC so add the
compatible to the hx83102 bindings file.

> Thank you again for taking the time out of your busy schedule to guide me.

The best way you can thank me is to teach others that you're working
with the lessons you've learned about working with the upstream kernel
mailing lists and sending patches. Maybe provide some internal
documentation for other new engineers to follow. :-P

-Doug