linux-kernel - Re: [PATCH v3 3/4] PCI: dwc: Reduce DT reads by allocating host bridge via DWC glue driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250124093635.hemydca7d7zeajaa@thinkpad>
Date: Fri, 24 Jan 2025 15:06:35 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Krishna Chaitanya Chundru <quic_krichai@...cinc.com>
Cc: Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>,
	cros-qcom-dts-watchers@...omium.org,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Jingoo Han <jingoohan1@...il.com>, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, quic_vbadigan@...cinc.com,
	quic_vpernami@...cinc.com, quic_mrana@...cinc.com,
	mmareddy@...cinc.com
Subject: Re: [PATCH v3 3/4] PCI: dwc: Reduce DT reads by allocating host
 bridge via DWC glue driver

On Fri, Jan 24, 2025 at 01:56:25PM +0530, Krishna Chaitanya Chundru wrote:
> 
> 
> On 1/24/2025 11:48 AM, Manivannan Sadhasivam wrote:
> > On Tue, Jan 21, 2025 at 02:32:21PM +0530, Krishna Chaitanya Chundru wrote:
> > > Allow DWC glue drivers to allocate the host bridge, avoiding redundant
> > > device tree reads primarily in dw_pcie_ecam_supported().
> > > 
> > 
> > I don't understand what you mean by 'redundant device tree reads'. Please
> > explain.
> > 
> In dw_pcie_ecam_supported () we are trying to read bus-range to find
> maximum bus range value. devm_pci_alloc_host_bridge() is already reading
> bus range it. If we move devm_pci_alloc_host_bridge() to start of the
> controller probe we can avoid reading the dt and use values stored in the
> host bridge.

This is the exact information you should put into the description. Do not assume
that the readers will have the background.

> This was recommended by bjorn in the v2.
> 

Then you should add 'Suggested-by' tag.

- Mani

-- 
மணிவண்ணன் சதாசிவம்