linux-kernel - Re: [PATCH v2] scsi: ufs: core: Ensure clk_gating.lock is used only after initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bd2757e-ecc9-481c-b8c7-12fb68e0f526@acm.org>
Date: Fri, 24 Jan 2025 09:47:34 -0800
From: Bart Van Assche <bvanassche@....org>
To: Avri Altman <avri.altman@....com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 Manivannan Sadhasivam <manisadhasivam.linux@...il.com>,
 Geert Uytterhoeven <geert@...ux-m68k.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH v2] scsi: ufs: core: Ensure clk_gating.lock is used only
 after initialization

On 1/23/25 11:33 PM, Avri Altman wrote:
> +	/*
> +	 * Initialize clk_gating.lock early since it is being used in
> +	 * ufshcd_setup_clocks()
> +	 */
> +	if (ufshcd_is_clkgating_allowed(hba))
> +		spin_lock_init(&hba->clk_gating.lock);

Initializing a spinlock is a very fast operation so please do this
unconditionally.

Thanks,

Bart.