linux-kernel - RE: [PATCH v2] scsi: ufs: core: Ensure clk_gating.lock is used only after initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB6575F185D39AA7BB10C668B4FCE22@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Sat, 25 Jan 2025 07:32:10 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Manivannan
 Sadhasivam <manisadhasivam.linux@...il.com>, Geert Uytterhoeven
	<geert@...ux-m68k.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: RE: [PATCH v2] scsi: ufs: core: Ensure clk_gating.lock is used only
 after initialization

> On 1/23/25 11:33 PM, Avri Altman wrote:
> > +     /*
> > +      * Initialize clk_gating.lock early since it is being used in
> > +      * ufshcd_setup_clocks()
> > +      */
> > +     if (ufshcd_is_clkgating_allowed(hba))
> > +             spin_lock_init(&hba->clk_gating.lock);
> 
> Initializing a spinlock is a very fast operation so please do this unconditionally.
Done.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.