linux-kernel - Re: [PATCH] posix-clock: Remove duplicate ioctl handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <06196213-3106-4b69-a15d-4b2e4ac6f187@app.fastmail.com>
Date: Sat, 25 Jan 2025 15:28:29 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 "Anna-Maria Gleixner" <anna-maria@...utronix.de>,
 "Frederic Weisbecker" <frederic@...nel.org>,
 "Thomas Gleixner" <tglx@...utronix.de>
Cc: linux-kernel@...r.kernel.org,
 "Richard Cochran" <richardcochran@...il.com>,
 "Cyrill Gorcunov" <gorcunov@...il.com>
Subject: Re: [PATCH] posix-clock: Remove duplicate ioctl handler

On Sat, Jan 25, 2025, at 11:20, Thomas Weißschuh wrote:
>  static int posix_clock_open(struct inode *inode, struct file *fp)
>  {
>  	int err;
> @@ -174,7 +154,7 @@ static const struct file_operations 
> posix_clock_file_operations = {
>  	.open		= posix_clock_open,
>  	.release	= posix_clock_release,
>  #ifdef CONFIG_COMPAT
> -	.compat_ioctl	= posix_clock_compat_ioctl,
> +	.compat_ioctl	= posix_clock_ioctl,
>  #endif

I would remove the #ifdef/#endif as well here. I would also suggest
using compat_ptr_ioctl(), so on s390 the pointers get converted
correctly, even if it clears the upper bit on the integer arguments.

      Arnd