linux-kernel - [PATCH] serial: pic32: Fix build warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250126163115.3200308-1-eleanor15x@gmail.com>
Date: Mon, 27 Jan 2025 00:31:15 +0800
From: Yu-Chun Lin <eleanor15x@...il.com>
To: gregkh@...uxfoundation.org,
	jirislaby@...nel.org
Cc: linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org,
	jserv@...s.ncku.edu.tw,
	visitorckw@...il.com,
	Yu-Chun Lin <eleanor15x@...il.com>,
	kernel test robot <lkp@...el.com>
Subject: [PATCH] serial: pic32: Fix build warning when CONFIG_OF is disabled

As reported by the kernel test robot, the following warning occurs:

>> drivers/tty/serial/pic32_uart.c:904:34: warning: 'pic32_serial_dt_ids' defined but not used [-Wunused-const-variable=]
     904 | static const struct of_device_id pic32_serial_dt_ids[] = {
         |                                  ^~~~~~~~~~~~~~~~~~~

The 'pic32_serial_dt_ids' array is only used when CONFIG_OF is enabled.
Wrapping its definition and 'MODULE_DEVICE_TABLE' in '#ifdef CONFIG_OF'
prevents a compiler warning when OF is disabled.

Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501260006.ecUsBidz-lkp@intel.com/
Signed-off-by: Yu-Chun Lin <eleanor15x@...il.com>
---
 drivers/tty/serial/pic32_uart.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
index 14d50bd7f1bd..a228a55102c6 100644
--- a/drivers/tty/serial/pic32_uart.c
+++ b/drivers/tty/serial/pic32_uart.c
@@ -948,11 +948,13 @@ static void pic32_uart_remove(struct platform_device *pdev)
 	pic32_sports[sport->idx] = NULL;
 }
 
+#ifdef CONFIG_OF
 static const struct of_device_id pic32_serial_dt_ids[] = {
 	{ .compatible = "microchip,pic32mzda-uart" },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, pic32_serial_dt_ids);
+#endif
 
 static struct platform_driver pic32_uart_platform_driver = {
 	.probe		= pic32_uart_probe,
-- 
2.43.0