linux-kernel - Re: [PATCH v3 2/2] scsi: ufs: Fix toggling of clk_gating.state when clock gating is not allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f069e33f01f8489b4baa8d1e5b3db4eb055ff118.camel@gmail.com>
Date: Sun, 26 Jan 2025 22:55:22 +0100
From: Bean Huo <huobean@...il.com>
To: Avri Altman <avri.altman@....com>, "Martin K . Petersen"
	 <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Manivannan
 Sadhasivam <manisadhasivam.linux@...il.com>, Bart Van Assche
 <bvanassche@....org>, Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH v3 2/2] scsi: ufs: Fix toggling of clk_gating.state when
 clock gating is not allowed

On Sun, 2025-01-26 at 08:45 +0200, Avri Altman wrote:
>         } else if (!ret && on && hba->clk_gating.is_initialized) {
>                 scoped_guard(spinlock_irqsave, &hba->clk_gating.lock)
>                         hba->clk_gating.state = CLKS_ON;
>                 trace_ufshcd_clk_gating(dev_name(hba->dev)

Consolidating all clock-related initialization into a single function,
such as ufshcd_init_clocks(), should be considered.