linux-kernel - RE: [PATCH v3 2/2] scsi: ufs: Fix toggling of clk_gating.state when clock gating is not allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB6575B1329711C4BE5D75D0B8FCEC2@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Mon, 27 Jan 2025 07:07:40 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bean Huo <huobean@...il.com>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Manivannan
 Sadhasivam <manisadhasivam.linux@...il.com>, Bart Van Assche
	<bvanassche@....org>, Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: RE: [PATCH v3 2/2] scsi: ufs: Fix toggling of clk_gating.state when
 clock gating is not allowed

> On Sun, 2025-01-26 at 08:45 +0200, Avri Altman wrote:
> >         } else if (!ret && on && hba->clk_gating.is_initialized) {
> >                 scoped_guard(spinlock_irqsave, &hba->clk_gating.lock)
> >                         hba->clk_gating.state = CLKS_ON;
> >                 trace_ufshcd_clk_gating(dev_name(hba->dev)
> 
> Consolidating all clock-related initialization into a single function, such as
> ufshcd_init_clocks(), should be considered.
Hi Bean,
I don't think it will resolve the issue that is addressed in this patch.

However, consolidating all clock-related initialization into a single function, is indeed a good idea.
I might try to do that - but in another patch.

Thanks,
Avri