linux-kernel - Re: [LSF/MM/BPF TOPIC] Overhauling hot page detection and promotion based on PTE A bit scanning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c805e3c-4d5d-6880-7e65-cce1041f7d35@google.com>
Date: Sun, 26 Jan 2025 23:01:25 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: Raghavendra K T <raghavendra.kt@....com>
cc: Hyeonggon Yoo <hyeonggon.yoo@...com>, 
    "linux-mm@...ck.org" <linux-mm@...ck.org>, 
    "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, 
    "lsf-pc@...ts.linux-foundation.org" <lsf-pc@...ts.linux-foundation.org>, 
    "bharata@....com" <bharata@....com>, kernel_team@...ynix.com, 
    42.hyeyoo@...il.com, "gourry@...rry.net" <gourry@...rry.net>, 
    "nehagholkar@...a.com" <nehagholkar@...a.com>, 
    "abhishekd@...a.com" <abhishekd@...a.com>, 
    "ying.huang@...ux.alibaba.com" <ying.huang@...ux.alibaba.com>, 
    "nphamcs@...il.com" <nphamcs@...il.com>, 
    "hannes@...xchg.org" <hannes@...xchg.org>, 
    "feng.tang@...el.com" <feng.tang@...el.com>, 
    "kbusch@...a.com" <kbusch@...a.com>, 
    "Hasan.Maruf@....com" <Hasan.Maruf@....com>, 
    "sj@...nel.org" <sj@...nel.org>, "david@...hat.com" <david@...hat.com>, 
    "willy@...radead.org" <willy@...radead.org>, 
    "k.shutemov@...il.com" <k.shutemov@...il.com>, 
    "mgorman@...hsingularity.net" <mgorman@...hsingularity.net>, 
    "vbabka@...e.cz" <vbabka@...e.cz>, "hughd@...gle.com" <hughd@...gle.com>, 
    "shy828301@...il.com" <shy828301@...il.com>, 
    "liam.howlett@...cle.com" <liam.howlett@...cle.com>, 
    "peterz@...radead.org" <peterz@...radead.org>, 
    "mingo@...hat.com" <mingo@...hat.com>, 
    "nadav.amit@...il.com" <nadav.amit@...il.com>, 
    "shivankg@....com" <shivankg@....com>, "ziy@...dia.com" <ziy@...dia.com>, 
    "jhubbard@...dia.com" <jhubbard@...dia.com>, 
    "AneeshKumar.KizhakeVeetil@....com" <AneeshKumar.KizhakeVeetil@....com>, 
    "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
    "jon.grimm@....com" <jon.grimm@....com>, 
    "santosh.shukla@....com" <santosh.shukla@....com>, 
    "Michael.Day@....com" <Michael.Day@....com>, 
    "riel@...riel.com" <riel@...riel.com>, 
    "weixugc@...gle.com" <weixugc@...gle.com>, 
    "leesuyeon0506@...il.com" <leesuyeon0506@...il.com>, honggyu.kim@...com, 
    "leillc@...gle.com" <leillc@...gle.com>, 
    "kmanaouil.dev@...il.com" <kmanaouil.dev@...il.com>, 
    "rppt@...nel.org" <rppt@...nel.org>, 
    "dave.hansen@...el.com" <dave.hansen@...el.com>, yuanchu@...gle.com
Subject: Re: [LSF/MM/BPF TOPIC] Overhauling hot page detection and promotion
 based on PTE A bit scanning

On Fri, 24 Jan 2025, Raghavendra K T wrote:

> On 1/24/2025 11:23 AM, Hyeonggon Yoo wrote:
> > 
> > 
> > On 1/23/2025 7:57 PM, Raghavendra K T wrote:
> > > Bharata and I would like to propose the following topic for LSFMM.
> > > 
> > > Topic: Overhauling hot page detection and promotion based on PTE A bit
> > > scanning.
> [...]
> > > Here is the list of potential discussion points:
> > > 1. Other improvements and enhancements to PTE A bit scanning approach. Use
> > > of
> > > multiple kernel threads, throttling improvements, promotion policies,
> > > per-process
> > > opt-in via prctl, virtual vs physical address based scanning, tuning hot
> > > page
> > > detection algorithm etc.
> > 
> > Yuanchu's MGLRU periodic aging series [1] seems quite relevant here,
> > you might want to look at it. adding Yuanchu to Cc.
> 
> Thank you for pointing that.
> 

+1.  Yuanchu, do you have ideas for how MGLRU periodic aging and working 
set can play a role in this?

> > By the way, do you have any reason why you'd prefer opt-in prctl
> > over per-memcg control?
> > 
> 
> opt-in prctl came in the MM alignment discussion, and have added that.

Are you planning on sending a refresh of that patch series? :)

> per-memcg also definitely makes sense. I am not aware which is the most
> used usecase. But adding provision for both with one having more
> priority over other may be the way to go.
> 

I would suggest leveraging prctl() for this as opposed to memcg.  I think 
making this part of memcg is beyond the scope for what memcg is intended 
to do, limitation of memory resources, similar to the recent discussions 
on per-cgroup control for THP.

Additionally, the current memcg configuration of the system may also not 
be convenient for using for this purpose, especially if one process should 
be opted out in the memcg hierarchy.  Requiring users to change how their 
memcg is configured just to opt out would be rather unfortunate.

> Overall point here is to save time in unnecessary scanning.
> will be adding prctl in the upcoming version to start with.
> 

Fully agreed.

Thanks very much for proposing this topic, Raghu, I think it will be very 
useful to discuss!  Looking forward to it!