Message-ID: <a4595e44-bf57-4e6e-8e43-a502381707a5@amd.com>
Date: Mon, 27 Jan 2025 12:41:49 +0530
From: Raghavendra K T <raghavendra.kt@....com>
To: David Rientjes <rientjes@...gle.com>
Cc: Hyeonggon Yoo <hyeonggon.yoo@...com>,
 "linux-mm@...ck.org" <linux-mm@...ck.org>,
 "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
 "lsf-pc@...ts.linux-foundation.org" <lsf-pc@...ts.linux-foundation.org>,
 "bharata@....com" <bharata@....com>, kernel_team@...ynix.com,
 42.hyeyoo@...il.com, "gourry@...rry.net" <gourry@...rry.net>,
 "nehagholkar@...a.com" <nehagholkar@...a.com>,
 "abhishekd@...a.com" <abhishekd@...a.com>,
 "ying.huang@...ux.alibaba.com" <ying.huang@...ux.alibaba.com>,
 "nphamcs@...il.com" <nphamcs@...il.com>,
 "hannes@...xchg.org" <hannes@...xchg.org>,
 "feng.tang@...el.com" <feng.tang@...el.com>,
 "kbusch@...a.com" <kbusch@...a.com>,
 "Hasan.Maruf@....com" <Hasan.Maruf@....com>, "sj@...nel.org"
 <sj@...nel.org>, "david@...hat.com" <david@...hat.com>,
 "willy@...radead.org" <willy@...radead.org>,
 "k.shutemov@...il.com" <k.shutemov@...il.com>,
 "mgorman@...hsingularity.net" <mgorman@...hsingularity.net>,
 "vbabka@...e.cz" <vbabka@...e.cz>, "hughd@...gle.com" <hughd@...gle.com>,
 "shy828301@...il.com" <shy828301@...il.com>,
 "liam.howlett@...cle.com" <liam.howlett@...cle.com>,
 "peterz@...radead.org" <peterz@...radead.org>,
 "mingo@...hat.com" <mingo@...hat.com>,
 "nadav.amit@...il.com" <nadav.amit@...il.com>,
 "shivankg@....com" <shivankg@....com>, "ziy@...dia.com" <ziy@...dia.com>,
 "jhubbard@...dia.com" <jhubbard@...dia.com>,
 "AneeshKumar.KizhakeVeetil@....com" <AneeshKumar.KizhakeVeetil@....com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "jon.grimm@....com" <jon.grimm@....com>,
 "santosh.shukla@....com" <santosh.shukla@....com>,
 "Michael.Day@....com" <Michael.Day@....com>,
 "riel@...riel.com" <riel@...riel.com>,
 "weixugc@...gle.com" <weixugc@...gle.com>,
 "leesuyeon0506@...il.com" <leesuyeon0506@...il.com>, honggyu.kim@...com,
 "leillc@...gle.com" <leillc@...gle.com>,
 "kmanaouil.dev@...il.com" <kmanaouil.dev@...il.com>,
 "rppt@...nel.org" <rppt@...nel.org>,
 "dave.hansen@...el.com" <dave.hansen@...el.com>, yuanchu@...gle.com
Subject: Re: [LSF/MM/BPF TOPIC] Overhauling hot page detection and promotion
 based on PTE A bit scanning



On 1/27/2025 12:31 PM, David Rientjes wrote:
> On Fri, 24 Jan 2025, Raghavendra K T wrote:
[...]
> 
>>> By the way, do you have any reason why you'd prefer opt-in prctl
>>> over per-memcg control?
>>>
>>
>> opt-in prctl came in the MM alignment discussion, and have added that.
> 
> Are you planning on sending a refresh of that patch series? :)

Hello David,
Current plan is to send by next week.
(Because after measuring the per mm latency and overall latency to do
full scan, I was thinking to add parallel scanning in next version itself).

> 
>> per-memcg also definitely makes sense. I am not aware which is the most
>> used usecase. But adding provision for both with one having more
>> priority over other may be the way to go.
>>
> 
> I would suggest leveraging prctl() for this as opposed to memcg.  I think
> making this part of memcg is beyond the scope for what memcg is intended
> to do, limitation of memory resources, similar to the recent discussions
> on per-cgroup control for THP.
> 
> Additionally, the current memcg configuration of the system may also not
> be convenient for using for this purpose, especially if one process should
> be opted out in the memcg hierarchy.  Requiring users to change how their
> memcg is configured just to opt out would be rather unfortunate.
> 
>> Overall point here is to save time in unnecessary scanning.
>> will be adding prctl in the upcoming version to start with.
>>
> 
> Fully agreed.
> 
> Thanks very much for proposing this topic, Raghu, I think it will be very
> useful to discuss!  Looking forward to it!

Thank you.

- Raghu

Powered by blists - more mailing lists