linux-kernel - Re: [PATCH v2 net-next] ixgbe: Fix endian handling for ACI descriptor registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f12d571-44bd-4737-a6df-e9d11a0a9c78@intel.com>
Date: Mon, 27 Jan 2025 12:30:17 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@...il.com>
CC: Simon Horman <horms@...nel.org>, <michal.swiatkowski@...ux.intel.com>,
	<anthony.l.nguyen@...el.com>, <piotr.kwapulinski@...el.com>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <intel-wired-lan@...ts.osuosl.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net-next] ixgbe: Fix endian handling for ACI descriptor
 registers

On 1/21/25 14:50, Dheeraj Reddy Jonnalagadda wrote:
>>
>> @Dheeraj, do you want to hone your minimal fix to avoid sparse warnings?
> 
> Sure, I will update the patch to avoid sparse warnings.
> 
>> follow up question: do you want to proceed with a full conversion?
>>
>> @Michal is going to send patches that depend on this "full conversion"
>> next month, so he could also take care of the "full conversion".
> 
>   I don't mind sending a patch with the full conversion. Although that
>   would have quite a few changes. To clarify
> 
>   1. Are we updating both @reg and @value to be __le32 ?
>   2. Should we also update ixgbe_read_reg() to also handle and return
>      __le32 values?
> 
> -Dheeraj

Hi, noone objected, so the answer is 2 x Yes