linux-kernel - Re: [PATCH bpf v2 1/2] samples/hid: remove unnecessary -I flags from libbpf EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250127-mottled-lean-waxbill-6fd7a1@l-nschier-nb>
Date: Mon, 27 Jan 2025 12:32:19 +0100
From: Nicolas Schier <n.schier@....de>
To: Jinghao Jia <jinghao7@...inois.edu>
Cc: Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Ruowen Qin <ruqin@...hat.com>, bpf@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH bpf v2 1/2] samples/hid: remove unnecessary -I flags from
 libbpf EXTRA_CFLAGS

On Mon, Jan 27, 2025 at 03:37:56AM -0600, Jinghao Jia wrote:
> On 1/27/25 3:29 AM, Nicolas Schier wrote:
> > On Thu, Jan 23, 2025 at 02:19:49AM -0600, Jinghao Jia wrote:
> >> Commit 5a6ea7022ff4 ("samples/bpf: Remove unnecessary -I flags from
> >> libbpf EXTRA_CFLAGS") fixed the build error caused by redundant include
> >> path for samples/bpf, but not samples/hid.
> >>
> >> Apply the same fix on samples/hid as well.
> >>
> >> Fixes: 13b25489b6f8 ("kbuild: change working directory to external module directory with M=")
> > 
> > I can't see a relation between this patch and the referenced commit.
> > Can you please check whether the 'Fixes' is (still?) valid here?
> > 
> > Kind regards,
> > Nicolas
> > 
> 
> The 'Fixes' is from commit 5a6ea7022ff4 ("samples/bpf: Remove unnecessary
> -I flags from libbpf EXTRA_CFLAGS") that fixes the equivalent issue in
> samples/bpf --- according to its commit message, commit 13b25489b6f8
> ("kbuild: change working directory to external module directory with M=")
> is the commit that breaks the libbpf build in the samples.

ah sorry, I should have read 5a6ea7022ff4 before.  Thanks for
clarification.

Kind regards,
Nicolas