linux-kernel - Re: [PATCH 2/3] dt-bindings: firmware: stratix10: Convert to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250127170705.12988-1-mahesh.rao@intel.com>
Date: Tue, 28 Jan 2025 01:07:05 +0800
From: Mahesh Rao <mahesh.rao@...el.com>
To: conor@...nel.org
Cc: conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dinguyen@...nel.org,
	hao.wu@...el.com,
	krzk+dt@...nel.org,
	krzysztof.kozlowski@...aro.org,
	linux-fpga@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mahesh.rao@...era.com,
	mahesh.rao@...el.com,
	mdf@...nel.org,
	robh@...nel.org,
	trix@...hat.com,
	yilun.xu@...el.com
Subject: Re: [PATCH 2/3] dt-bindings: firmware: stratix10: Convert to json-schema

Hi Conor Dooley,

On Wed, 22 Jan 2025 18:40:41 +0000, Conor Dooley wrote:
> > Convert intel,stratix10-svc service layer devicetree binding file from
> > freeform format to json-schema.
> 

> > +
> > +  method:
> > +    enum: [smc, hvc]
> > +    description: supervisory call method to be used for the service layer.
> 
> This looks to be missing a type (string) and an explanation of what "smc" and
> "hvc" are.
> 

Thanks for pointing out , will do the change in next revision.

> > +
> > +  fpga-mgr:
> > +    $ref: /schemas/fpga/intel,stratix10-soc-fpga-mgr.yaml
> > +    description: Optional child node for fpga manager to perform fabric
> configuration.
> 
> This is new and not justified in your commit message. Please explain where
> this has come from in v2.
> 
> Cheers,
> Conor.
> 

Sure, this is an optional child node/driver present in the device tree for
the Agilex SoC devices, but it was not mentioned in the text documentation.
Therefore, I had included it here. I will provide more details about this
change in the next version.

Best Regards
Mahesh Rao