linux-kernel - Re: [PATCH] arm64: dts: ti: am64-phyboard-electra: Add DT overlay for X27 connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2dd9bffa-17d5-4635-b2da-15f59cf07590@kernel.org>
Date: Mon, 27 Jan 2025 18:24:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Schultz <d.schultz@...tec.de>, nm@...com, vigneshr@...com,
 kristo@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: w.egorov@...tec.de, upstream@...ts.phytec.de
Subject: Re: [PATCH] arm64: dts: ti: am64-phyboard-electra: Add DT overlay for
 X27 connector

On 27/01/2025 07:57, Daniel Schultz wrote:
> +&main_spi1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_spi1_pins_default>;
> +	ti,pindir-d0-out-d1-in = <1>;
> +	status = "okay";
> +
> +	spidev@0 {


Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


> +		compatible = "rohm,dh2228fv";


That's not the device you have there. You cannot use other compatibles.


Best regards,
Krzysztof