linux-kernel - Re: [PATCH] arm64: dts: ti: am64-phyboard-electra: Add DT overlay for X27 connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f1d962f-ecfa-40e1-b699-95c38a853d15@phytec.de>
Date: Tue, 28 Jan 2025 08:43:41 +0000
From: Daniel Schultz <D.Schultz@...tec.de>
To: Krzysztof Kozlowski <krzk@...nel.org>, "nm@...com" <nm@...com>,
	"vigneshr@...com" <vigneshr@...com>, "kristo@...nel.org" <kristo@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Wadim Egorov <W.Egorov@...tec.de>, "upstream@...ts.phytec.de"
	<upstream@...ts.phytec.de>
Subject: Re: [PATCH] arm64: dts: ti: am64-phyboard-electra: Add DT overlay for
 X27 connector

Hi,

On 27.01.25 18:24, Krzysztof Kozlowski wrote:
> On 27/01/2025 07:57, Daniel Schultz wrote:
>> +&main_spi1 {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&main_spi1_pins_default>;
>> +	ti,pindir-d0-out-d1-in = <1>;
>> +	status = "okay";
>> +
>> +	spidev@0 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
>> +		compatible = "rohm,dh2228fv";
>
> That's not the device you have there. You cannot use other compatibles.

I will remove that device for now and see if I can find a supported 
device on Sparkfun or similar, which I can add later.

- Daniel

>
>
> Best regards,
> Krzysztof