linux-kernel - Re: [PATCH v1 1/2] dt-bindings: display: panel: Add compatible for CSOT PNA957QT1-1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XcVnkYSzanqinLX65gRc5434WGbvauavBZPpabfT-2Yw@mail.gmail.com>
Date: Mon, 27 Jan 2025 09:33:08 -0800
From: Doug Anderson <dianders@...omium.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, airlied@...il.com, 
	simona@...ll.ch, maarten.lankhorst@...ux.intel.com, mripard@...nel.org, 
	tzimmermann@...e.de, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v1 1/2] dt-bindings: display: panel: Add compatible for
 CSOT PNA957QT1-1

Langyan,

On Mon, Jan 27, 2025 at 12:43 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Mon, Jan 27, 2025 at 09:46:04AM +0800, Langyan Ye wrote:
> > Add a new compatible for the panel CSOT PNA957QT1-1. This panel
> > uses HX83102 IC, so add the compatible to the hx83102 binding files.
> >
> > Signed-off-by: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
> > ---
> >  .../devicetree/bindings/display/panel/himax,hx83102.yaml        | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
> > index c649fb085833..d876269e1fac 100644
> > --- a/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/himax,hx83102.yaml
> > @@ -18,6 +18,8 @@ properties:
> >        - enum:
> >            # Boe nv110wum-l60 11.0" WUXGA TFT LCD panel
> >            - boe,nv110wum-l60
> > +          # CSOT pna957qt1-1 10.95" WUXGA TFT LCD panel
> > +          - csot,pna957qt1-1
>
> You need to add such vendor prefix first.

Since you may not know what this means, Krzysztof expects you to add a
new patch to the front of your series adding an entry into
"Documentation/devicetree/bindings/vendor-prefixes.yaml" for "csot".
Based on my experience with eDP panels made by them, presumably "csot"
is "China Star Optoelectronics Technology Co., Ltd" ?


> It does not look like you tested the DTS against bindings. Please run
> 'make dtbs_check W=1' (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.

It's important that you figure out how to do the above so you can
validate your bindings yourself.


> Point us to your DTS so we can validate that you really tested it.

Krzysztof: not sure what you're asking for here. I assume Langyan is
posting support for this panel for hardware they are trying to bring
up, and the device tree may not be officially posted anywhere yet.
This is not really a requirement, is it? Given that Langyan is just
adding a compatible to an existing binding, it seems like we can be
fairly certain that the binding is fine without needing an extra dts
example, right?

-Doug