linux-kernel - Re: [PATCH v1 2/2] drm/panel: panel-himax-hx83102: support for csot-pna957qt1-1 MIPI-DSI panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=VBYbY6x0xmDAbXPD7yfyJm5XLqdHBWC-8RcyVCkXasxA@mail.gmail.com>
Date: Mon, 27 Jan 2025 09:33:18 -0800
From: Doug Anderson <dianders@...omium.org>
To: Langyan Ye <yelangyan@...qin.corp-partner.google.com>
Cc: neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, airlied@...il.com, 
	simona@...ll.ch, maarten.lankhorst@...ux.intel.com, mripard@...nel.org, 
	tzimmermann@...e.de, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] drm/panel: panel-himax-hx83102: support for
 csot-pna957qt1-1 MIPI-DSI panel

Hi,

On Sun, Jan 26, 2025 at 5:46 PM Langyan Ye
<yelangyan@...qin.corp-partner.google.com> wrote:
>
> The csot-pna957qt1-1 is a 10.95" TFT panel. The MIPI controller on this
> panel is the same as the other panels here, so add this panel to this
> driver. From the datasheet, MIPI needs to keep the LP11 state before
> the lcm_reset pin is pulled high, so increase lp11_before_reset flag.

Drop the part about LP11. You must have copied it from an earlier
panel where that flag still made sense. It doesn't make sense to talk
about given the current state of the driver.


> @@ -396,6 +397,103 @@ static int ivo_t109nw41_init(struct hx83102 *ctx)
>         return dsi_ctx.accum_err;
>  };
>
> +static int csot_pna957qt1_1_init(struct hx83102 *ctx)
> +{

nit: can you keep the functions sorted to match the bindings? So this
function would be in between the BOE init function and the IVO init
function?


> @@ -462,6 +560,28 @@ static const struct hx83102_panel_desc ivo_t109nw41_desc = {
>         .init = ivo_t109nw41_init,
>  };
>
> +static const struct drm_display_mode csot_pna957qt1_1_default_mode = {
> +       .clock = 177958,

nit: similarly, sort the default_mode / desc between the BOE one and
the IVO one.


Other than small nits, this looks pretty nice to me and I'd expect to
give a Reviewed-by tag on v2 unless something major changes.


-Doug