linux-kernel - Re: RE: [PATCH v2 0/7] x86/resctrl : Support L3 Smart Data Cache Injection Allocation Enforcement (SDCIAE)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <faaf5c41-43a9-4138-aa39-6c895930eb5e@amd.com>
Date: Mon, 27 Jan 2025 12:25:40 -0600
From: "Moger, Babu" <babu.moger@....com>
To: "Luck, Tony" <tony.luck@...el.com>,
 "Chatre, Reinette" <reinette.chatre@...el.com>,
 "tglx@...utronix.de" <tglx@...utronix.de>,
 "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>,
 "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
Cc: "Yu, Fenghua" <fenghua.yu@...el.com>, "x86@...nel.org" <x86@...nel.org>,
 "hpa@...or.com" <hpa@...or.com>,
 "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
 "paulmck@...nel.org" <paulmck@...nel.org>,
 "thuth@...hat.com" <thuth@...hat.com>,
 "rostedt@...dmis.org" <rostedt@...dmis.org>,
 "xiongwei.song@...driver.com" <xiongwei.song@...driver.com>,
 "pawan.kumar.gupta@...ux.intel.com" <pawan.kumar.gupta@...ux.intel.com>,
 "jpoimboe@...nel.org" <jpoimboe@...nel.org>,
 "daniel.sneddon@...ux.intel.com" <daniel.sneddon@...ux.intel.com>,
 "thomas.lendacky@....com" <thomas.lendacky@....com>,
 "perry.yuan@....com" <perry.yuan@....com>,
 "sandipan.das@....com" <sandipan.das@....com>,
 "Huang, Kai" <kai.huang@...el.com>, "seanjc@...gle.com" <seanjc@...gle.com>,
 "Li, Xin3" <xin3.li@...el.com>, "ebiggers@...gle.com" <ebiggers@...gle.com>,
 "andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
 "mario.limonciello@....com" <mario.limonciello@....com>,
 "tan.shaopeng@...itsu.com" <tan.shaopeng@...itsu.com>,
 "james.morse@....com" <james.morse@....com>,
 "peternewman@...gle.com" <peternewman@...gle.com>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "Eranian, Stephane" <eranian@...gle.com>, "corbet@....net" <corbet@....net>
Subject: Re: RE: [PATCH v2 0/7] x86/resctrl : Support L3 Smart Data Cache
 Injection Allocation Enforcement (SDCIAE)

Hi Tony,

Thanks for testing..

On 12/18/24 17:27, Luck, Tony wrote:
> I don't have an AMD system, so I added a couple of hacks to the code to pretend I did.
> My hacks might have missed something, so the below test may not fail for you.
> 
> My test:
> 
> # echo 1 > info/L3/io_alloc
> # cat info/L3/bit_usage
> 
> This gave me a console splat starting with:
> 
> [  163.801078] invalid mode for closid 14

I recreated the issue.

1124.714954] ------------[ cut here ]------------
[ 1124.714955] invalid mode for closid 15
[ 1124.714956] WARNING: CPU: 71 PID: 3553 at
arch/x86/kernel/cpu/resctrl/rdtgroup.c:1082 rdt_bit_usage_show+0x238/0x2d0


> 
> That happened because in rdt_bit_usage_show()
> 
>                 for (i = 0; i < closids_supported(); i++) {
>                         if (!closid_allocated(i))
>                                 continue;
>                         ctrl_val = resctrl_arch_get_config(r, dom, i,
>                                                            s->conf_type);
>                         mode = rdtgroup_mode_by_closid(i);
> 
> CLOSID 14 is my highest. It's supported, and allocated.
> 
> rdtgroup_mode_by_closid() searches rdt_all_groups to find
> one using CLOSID 14, but there isn't one. So it returns
> RDT_NUM_MODES
> 
> Maybe RDT_NUM_MODES isn't invalid in the switch()
> Looks like it should be same action as RDT_MODE_SHAREABLE?

Yes. That is correct. Will take care of this in next revision.
-- 
Thanks
Babu Moger