linux-kernel - Re: [PATCH] apparmor: use the condition in AA_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGudoHGswaubt5-rYNBy-whuf1_+F_gji_RshfM=hmXFF-58qg@mail.gmail.com>
Date: Mon, 27 Jan 2025 22:07:15 +0100
From: Mateusz Guzik <mjguzik@...il.com>
To: Ryan Lee <ryan.lee@...onical.com>
Cc: john.johansen@...onical.com, paul@...l-moore.com, 
	linux-kernel@...r.kernel.org, apparmor@...ts.ubuntu.com, 
	linux-security-module@...r.kernel.org
Subject: Re: [PATCH] apparmor: use the condition in AA_BUG_FMT even with debug disabled

On Mon, Jan 27, 2025 at 9:59 PM Ryan Lee <ryan.lee@...onical.com> wrote:
>
> For the record, a previous patch that removes the sock variable was
> previously accepted:
> https://lists.ubuntu.com/archives/apparmor/2025-January/013449.html
> (patch) and https://lists.ubuntu.com/archives/apparmor/2025-January/013463.html
> (ack from John Johansen)
>

That makes sense, but imo the posted patch is still warranted -- all
other debug macros (WARN_ON, VM_WARN_ON etc.) are expected to evaluate
the condition.

-- 
Mateusz Guzik <mjguzik gmail.com>