linux-kernel - Re: [PATCH v3 1/4] dt-bindings: PCI: qcom: add global interrupt for ipq5424

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02c7dc71-5048-4736-9e42-ef7a835168a8@quicinc.com>
Date: Tue, 28 Jan 2025 12:30:40 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <andersson@...nel.org>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <lpieralisi@...nel.org>, <kw@...ux.com>,
        <manivannan.sadhasivam@...aro.org>, <bhelgaas@...gle.com>,
        <konradybcio@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH v3 1/4] dt-bindings: PCI: qcom: add global interrupt for
 ipq5424



On 1/27/2025 12:55 PM, Krzysztof Kozlowski wrote:
> On Sat, Jan 25, 2025 at 09:29:17AM +0530, Manikanta Mylavarapu wrote:
>> Document the global interrupt found on IPQ5424 platform.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
>>  Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> index 7235d6554cfb..1fd6aea08bf0 100644
>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> @@ -49,11 +49,11 @@ properties:
>>  
>>    interrupts:
>>      minItems: 1
>> -    maxItems: 8
>> +    maxItems: 9
>>  
>>    interrupt-names:
>>      minItems: 1
>> -    maxItems: 8
>> +    maxItems: 9
> 
> You just added it for few other devices as well, like sdm845. If you
> raise one part of constrain, then you need to correct each block where
> old constrain was implied.
> 

Hi Krzysztof,

Thank you for reviewing the patch.

I will explicitly set the maxItems for other devices like sdm845 and msm8996 based on the
number of interrupts they support. This will ensure consistency across all devices.

Please correct me if my understanding is wrong.

Thanks & Regards,
Manikanta.