linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3ff05c1-6424-4ace-a873-ddf1a0d3d07d@kernel.org>
Date: Tue, 28 Jan 2025 10:22:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>, ath12k@...ts.infradead.org
Cc: linux-wireless@...r.kernel.org, Kalle Valo <kvalo@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: add wifi node for IPQ5332 based
 RDP441

On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
> +	/*                 Default Profile
> +	 * +============+==============+=====================+
> +	 * |            |              |                     |
> +	 * | Region     | Start Offset |       Size          |
> +	 * |            |              |                     |
> +	 * +------------+--------------+---------------------+
> +	 * |            |              |                     |
> +	 * |            |              |                     |
> +	 * |            |              |                     |
> +	 * | WLAN Q6    |  0x4A900000  |       43MB          |
> +	 * |            |              |                     |
> +	 * |            |              |                     |
> +	 * +------------+--------------+---------------------+
> +	 * | M3 Dump    |  0x4D400000  |       1MB           |
> +	 * +============+==============+=====================+
> +	 * |                                                 |
> +	 * |                                                 |
> +	 * |                                                 |
> +	 * |            Rest of memory for Linux             |
> +	 * |                                                 |
> +	 * |                                                 |
> +	 * |                                                 |
> +	 * +=================================================+
> +	 */
> +
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		q6_region: wcss@...00000 {
> +			reg = <0x0 0x4a900000 0x0 0x02b00000>;
> +			no-map;
> +		};
> +
> +		m3_dump: m3-dump@...00000 {

This fails with your wireless patchset.

> +			reg = <0x0 0x4D400000 0x0 0x100000>;
> +			no-map;
> +		};
> +	};
>  };
>  
>  &blsp1_i2c1 {
> @@ -63,3 +104,16 @@ data-pins {
>  		};
>  	};
>  };
> +
> +&wifi0 {
> +	memory-region = <&q6_region>, <&m3_dump>;
> +	memory-region-names = "q6-region", "m3-dump";

Binding said you have four items. I don't understand why this varies and
why this is 2 items instead.


Best regards,
Krzysztof