linux-kernel - Re: [PATCH v3 0/2] Fixup drm_atomic_helper_connector_hdmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65dc1384-88cc-480c-a028-f927ed2419df@collabora.com>
Date: Tue, 28 Jan 2025 13:09:40 +0200
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Maxime Ripard <mripard@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, kernel@...labora.com,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v3 0/2] Fixup drm_atomic_helper_connector_hdmi_check()

Hi Maxime,

On 1/28/25 11:58 AM, Maxime Ripard wrote:
> Hi,
> 
> On Tue, Jan 14, 2025 at 08:16:55PM +0200, Cristian Ciocaltea wrote:
>> Fix a NULL pointer dereference discovered while unloading a DRM module
>> and provide a test to make sure the helper works as expected in case the
>> connector's CRTC is shut down.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> 
> I'm sorry, I didn't realize it at the time but it looks like it was made
> redundant by another series that got merged about the same time you were
> sending this one:
> 
> https://patchwork.freedesktop.org/series/143378/
> 
> Sorry again,

No worries.

I checked the merged series and I think some bits from this series are
still applicable:

* Simplify the NULL verification by considering only the return of
connector_state_get_mode(), which gets rid of the redundant
'new_conn_state->crtc' check, but also covers the additional checks
already performed in that function.

* Update the newly introduced test case to also verify
{mode|connectors|active}_changed.

I could send those as v4, but probably it makes sense to drop this
series and start a new one - please let me know if you have a preference
here.

Thanks,
Cristian