linux-kernel - [PATCH 6/9] usb: cdns3: call cdns_power_is_lost() only once in cdns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250129105613.403923-6-theo.lebrun@bootlin.com>
Date: Wed, 29 Jan 2025 11:56:10 +0100
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: theo.lebrun@...tlin.com,
	mathias.nyman@...ux.intel.com
Cc: rogerq@...nel.org,
	peter.chen@...nel.org,
	pawell@...ence.com,
	gregkh@...uxfoundation.org,
	mathias.nyman@...el.com,
	gregory.clement@...tlin.com,
	thomas.petazzoni@...tlin.com,
	linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 6/9] usb: cdns3: call cdns_power_is_lost() only once in cdns_resume()

cdns_power_is_lost() does a register read.
Call it only once rather than twice.

Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
---
 drivers/usb/cdns3/core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
index 465e9267b49c..799987c88960 100644
--- a/drivers/usb/cdns3/core.c
+++ b/drivers/usb/cdns3/core.c
@@ -524,11 +524,12 @@ EXPORT_SYMBOL_GPL(cdns_suspend);
 
 int cdns_resume(struct cdns *cdns)
 {
+	bool power_lost = cdns_power_is_lost(cdns);
 	enum usb_role real_role;
 	bool role_changed = false;
 	int ret = 0;
 
-	if (cdns_power_is_lost(cdns)) {
+	if (power_lost) {
 		if (cdns->role_sw) {
 			cdns->role = cdns_role_get(cdns->role_sw);
 		} else {
@@ -553,7 +554,7 @@ int cdns_resume(struct cdns *cdns)
 	}
 
 	if (cdns->roles[cdns->role]->resume)
-		cdns->roles[cdns->role]->resume(cdns, cdns_power_is_lost(cdns));
+		cdns->roles[cdns->role]->resume(cdns, power_lost);
 
 	return 0;
 }
-- 
2.48.1