linux-kernel - Re: [PATCH v3 2/4] dt-bindings: clock: update interconnect cells for ipq5424

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c30cce4-eb9f-4fb9-b454-c6f5de604237@quicinc.com>
Date: Thu, 30 Jan 2025 12:26:10 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, <andersson@...nel.org>,
        <mturquette@...libre.com>, <sboyd@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <lpieralisi@...nel.org>,
        <kw@...ux.com>, <manivannan.sadhasivam@...aro.org>,
        <bhelgaas@...gle.com>, <konradybcio@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-pci@...r.kernel.org>
CC: <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: clock: update interconnect cells for
 ipq5424



On 1/28/2025 4:56 PM, Konrad Dybcio wrote:
> On 25.01.2025 4:59 AM, Manikanta Mylavarapu wrote:
>> Interconnect cells differ between the IPQ5332 and IPQ5424.
>> Therefore, update the interconnect cells according to the SoC.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
>>  .../devicetree/bindings/clock/qcom,ipq5332-gcc.yaml       | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml
>> index 1230183fc0a9..fac7922d2473 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq5332-gcc.yaml
>> @@ -35,8 +35,6 @@ properties:
>>        - description: PCIE 2-lane PHY3 pipe clock source
>>  
>>    '#power-domain-cells': false
>> -  '#interconnect-cells':
>> -    const: 1
>>  
>>  required:
>>    - compatible
>> @@ -54,6 +52,9 @@ allOf:
>>          clocks:
>>            maxItems: 5
>>  
>> +        '#interconnect-cells':
>> +          const: 1
>> +
>>    - if:
>>        properties:
>>          compatible:
>> @@ -65,6 +66,9 @@ allOf:
>>            minItems: 7
>>            maxItems: 7
>>  
>> +        '#interconnect-cells':
>> +          const: 2
> 
> Please apply some criticism to the review comments you receive.. this only
> makes sense for platforms using icc-rpm or icc-rpmh.
> 
> Since this driver registers an interconnect provider through icc_clk APIs,
> it explicitly uses a simple, onecell translation function to .get the nodes
> 
> Please drop this patch


Hi Konrad,

Thank you for pointing this.
I will drop the patch.

Thanks & Regards,
Manikanta.