linux-kernel - Re: [PATCH v2 1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC resets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6312f316-f407-494b-91c4-04d761396e22@postmarketos.org>
Date: Thu, 30 Jan 2025 14:29:31 +0300
From: Alexey Minnekhanov <alexeymin@...tmarketos.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Craig Tatlor <ctatlor97@...il.com>,
 Taniya Das <quic_tdas@...cinc.com>, linux-arm-msm@...r.kernel.org,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 phone-devel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC
 resets

On 1/30/25 11:35 AM, Krzysztof Kozlowski wrote:
> On Thu, Jan 30, 2025 at 12:23:25AM +0300, Alexey Minnekhanov wrote:
>> Add resets for eMMC/SD card blocks that were missed during initial
>> driver submission.
>>
>> Signed-off-by: Alexey Minnekhanov <alexeymin@...tmarketos.org>
>> Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for SDM660")
> 
> Your SoB is always the last tag, but repeating what I asked during
> previous review - what sort of bug is here? Missing feature is not a bug
> per se.
> 
> Best regards,
> Krzysztof
> 

I was hesitant about adding fixes tag myself, because there is no any 
user-observable bug being fixed here. In fact the behavior is unchanged, 
eMMC and SD worked fine before this and still work fine with this patch.
 From Linux side this is mostly for consistency with other 
younger/sibling SoCs, like MSM8998 & 8996 all have these resets 
specified. This will probably be much more useful for U-Boot port.

Perhaps fixes tag should be removed completely?

--
Regards,
Alexey