linux-kernel - Re: [PATCH v2 02/13] tests/acpi: virt: allow acpi table changes for a new table: HEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250130140324.06cdd4bf@foz.lan>
Date: Thu, 30 Jan 2025 14:03:24 +0100
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Igor Mammedov <imammedo@...hat.com>
Cc: "Michael S . Tsirkin" <mst@...hat.com>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, Shiju Jose <shiju.jose@...wei.com>,
 qemu-arm@...gnu.org, qemu-devel@...gnu.org, Ani Sinha
 <anisinha@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/13] tests/acpi: virt: allow acpi table changes for
 a new table: HEST

Em Wed, 29 Jan 2025 16:03:28 +0100
Igor Mammedov <imammedo@...hat.com> escreveu:

> On Wed, 29 Jan 2025 09:04:08 +0100
> Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:
> 
> > The DSDT table will also be affected by such change.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>  
> 
> move it right before the patch that would actually make changes to tables (10/13)

Table changes happens on two patches:

- patch 03/13: acpi/ghes: add a firmware file with HEST address

	HEST table was added here

- patch 10/13: arm/virt: Wire up a GED error device for ACPI / GHES 

	DSDT changes happen here.

If the idea is to avoid make check to fail between those two patches,
we need either to split them on 4 patches (one before/one after each
change) or do like I did on this series: whitelist before patch 3,
update after patch 10.

Regards,
Mauro

> 
> 
> > ---
> >  tests/data/acpi/aarch64/virt/HEST           | 0
> >  tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
> >  2 files changed, 2 insertions(+)
> >  create mode 100644 tests/data/acpi/aarch64/virt/HEST
> > 
> > diff --git a/tests/data/acpi/aarch64/virt/HEST b/tests/data/acpi/aarch64/virt/HEST
> > new file mode 100644
> > index 000000000000..e69de29bb2d1
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index dfb8523c8bf4..46298e38e7b8 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1 +1,3 @@
> >  /* List of comma-separated changed AML files to ignore */
> > +"tests/data/acpi/aarch64/virt/HEST",
> > +"tests/data/acpi/aarch64/virt/DSDT",  
> 
> the list in not complete so 'make check-qtest' still fails
> [12/13] has complete list of changed files
> 

Thanks,
Mauro