linux-kernel - Re: [PATCH v2 00/11] CRC64 library rework and x86 CRC optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5uWOnj8T7OO4LH8@kbusch-mbp>
Date: Thu, 30 Jan 2025 08:09:46 -0700
From: Keith Busch <kbusch@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	x86@...nel.org, linux-block@...r.kernel.org,
	Ard Biesheuvel <ardb@...nel.org>,
	Kent Overstreet <kent.overstreet@...ux.dev>,
	"Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH v2 00/11] CRC64 library rework and x86 CRC optimization

On Wed, Jan 29, 2025 at 07:51:19PM -0800, Eric Biggers wrote:
> Patch 11 wires up the same optimization to crc64_be() and crc64_nvme()
> (a.k.a. the old "crc64_rocksoft") which previously were unoptimized,

Yes, I mistakenly thought the name of the table in the spec was the
name of the CRC, but that was just referring to format of how the
parameters were displayed. It really should have been crc64_nvme, so
thank you for clearing up the naming confusion.

> improving the performance of those CRC functions by as much as 100x.

Awesome!

Looks good:

Acked-by: Keith Busch <kbusch@...nel.org>