linux-kernel - Re: [PATCH v2 00/11] CRC64 library rework and x86 CRC optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1plk4pbvw.fsf@ca-mkp.ca.oracle.com>
Date: Thu, 30 Jan 2025 10:20:15 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, x86@...nel.org,
        linux-block@...r.kernel.org, Ard Biesheuvel
 <ardb@...nel.org>,
        Keith Busch <kbusch@...nel.org>,
        Kent Overstreet
 <kent.overstreet@...ux.dev>,
        "Martin K . Petersen"
 <martin.petersen@...cle.com>
Subject: Re: [PATCH v2 00/11] CRC64 library rework and x86 CRC optimization


Eric,

> Patches 1-5 rework the CRC64 library along the lines of what I did for
> CRC32 and CRC-T10DIF in 6.14. They add direct support for
> architecture-specific optimizations, fix the naming of the NVME CRC64
> variant, and eliminate a pointless use of the crypto API.
>
> Patches 6-10 replace the existing x86 PCLMULQDQ optimized CRC code
> with new code that is shared among the different CRC variants and also
> adds VPCLMULQDQ support, greatly improving performance on recent CPUs.
> Patch 11 wires up the same optimization to crc64_be() and crc64_nvme()
> (a.k.a. the old "crc64_rocksoft") which previously were unoptimized,
> improving the performance of those CRC functions by as much as 100x.
> crc64_be is used by bcachefs, and crc64_nvme is used by blk-integrity.

Very nice!

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering