linux-kernel - [PATCH] jiffies: Cast to unsigned long for secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250130184320.69553-1-eahariha@linux.microsoft.com>
Date: Thu, 30 Jan 2025 18:43:17 +0000
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: Thomas Gleixner <tglx@...utronix.de>,
	Easwar Hariharan <eahariha@...ux.microsoft.com>,
	Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	linux-kernel@...r.kernel.org (open list)
Cc: stable@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	kernel test robot <lkp@...el.com>
Subject: [PATCH] jiffies: Cast to unsigned long for secs_to_jiffies() conversion

While converting users of msecs_to_jiffies(), lkp reported that some
range checks would always be true because of the mismatch between the
implied int value of secs_to_jiffies() vs the unsigned long
return value of the msecs_to_jiffies() calls it was replacing. Fix this
by casting secs_to_jiffies() values as unsigned long.

Fixes: b35108a51cf7ba ("jiffies: Define secs_to_jiffies()")
CC: stable@...r.kernel.org # 6.12+
CC: Andrew Morton <akpm@...ux-foundation.org>
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501301334.NB6NszQR-lkp@intel.com/
Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
---
 include/linux/jiffies.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/jiffies.h b/include/linux/jiffies.h
index ed945f42e064..0ea8c9887429 100644
--- a/include/linux/jiffies.h
+++ b/include/linux/jiffies.h
@@ -537,7 +537,7 @@ static __always_inline unsigned long msecs_to_jiffies(const unsigned int m)
  *
  * Return: jiffies value
  */
-#define secs_to_jiffies(_secs) ((_secs) * HZ)
+#define secs_to_jiffies(_secs) (unsigned long)((_secs) * HZ)
 
 extern unsigned long __usecs_to_jiffies(const unsigned int u);
 #if !(USEC_PER_SEC % HZ)
-- 
2.43.0