linux-kernel - Re: [PATCH] jiffies: Cast to unsigned long for secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <085b4f6b-0399-4b77-a2af-9bf2e19e5f62@linux.microsoft.com>
Date: Thu, 30 Jan 2025 11:25:10 -0800
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Geert Uytterhoeven <geert@...ux-m68k.org>,
 Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
 Miguel Ojeda <ojeda@...nel.org>, open list <linux-kernel@...r.kernel.org>,
 eahariha@...ux.microsoft.com, stable@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] jiffies: Cast to unsigned long for secs_to_jiffies()
 conversion

On 1/30/2025 10:43 AM, Easwar Hariharan wrote:
> While converting users of msecs_to_jiffies(), lkp reported that some
> range checks would always be true because of the mismatch between the
> implied int value of secs_to_jiffies() vs the unsigned long
> return value of the msecs_to_jiffies() calls it was replacing. Fix this
> by casting secs_to_jiffies() values as unsigned long.
> 
> Fixes: b35108a51cf7ba ("jiffies: Define secs_to_jiffies()")
> CC: stable@...r.kernel.org # 6.12+

Sorry, this should be 6.13+ since secs_to_jiffies() was introduced in
6.13-rc1, not 6.12-rc1. I was mislead by git describe output. Let me
send this as a v2.

Thanks,
Easwar (he/him)