linux-kernel - Re: [PATCH] b4: Include git notes when generating patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250130210453.GA615204@yaz-khff2.amd.com>
Date: Thu, 30 Jan 2025 16:04:53 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: Konstantin Ryabitsev <konstantin@...uxfoundation.org>
Cc: tools@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] b4: Include git notes when generating patches

On Thu, Jan 30, 2025 at 03:30:59PM -0500, Konstantin Ryabitsev wrote:
> On Thu, Jan 30, 2025 at 08:13:31PM +0000, Yazen Ghannam wrote:
> > By default, 'git show' will include git notes in its output. However,
> > this is not the case if '--format', or related flags, are given.
> > 
> > Include the '--notes' flag to include git notes in the generated patch.
> 
> I'd love to do that, but git-filter-repo currently doesn't do the right thing
> with notes, so anyone who starts to rely on notes will find that they are
> easily lost with most common b4 operations. There's a long-standing RFE to
> support notes with git-filter-repo:
> 
> https://github.com/newren/git-filter-repo/issues/22
> 
> Until that happens, I really don't want to pretend that we support notes,
> because this will result in bad experiences for most who try it.
> 

Right, I've encountered issues myself. I've found that the 'tip-commit'
cover letter strategy works, since git-filter-repo will only operate on
the final commit.

Could we document some tips for this topic? Or just leave it for now?

Thanks,
Yazen